Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation time broken after "Apple's Original Version" #63

Open
sgrandner opened this issue Oct 16, 2019 · 7 comments
Open

Animation time broken after "Apple's Original Version" #63

sgrandner opened this issue Oct 16, 2019 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest

Comments

@sgrandner
Copy link

sgrandner commented Oct 16, 2019

At the beginning the time for each animation seems okay until Apple's Original Version (not Unstable pipes which is similar) comes. After that the animations are only played half and it's getting really busy. This happens also if Repeat Each Animation is greater than 0.

This is related to #52 and #54.

  • Mac model: MacBook Pro
  • macOS version: 10.14.4
  • Brooklyn saver version: 2.0.1

Note: After disabling Apple's Original Version it's working.

@pedrommcarrasco
Copy link
Owner

That's an interesting one. I'll try to find some time to dig into it.
p.s.: Love your profile image @sgrandner! 👍

@pedrommcarrasco pedrommcarrasco added bug Something isn't working good first issue Good for newcomers Hacktoberfest labels Oct 17, 2019
@sgrandner
Copy link
Author

Thanks :)

Great screensaver by the way :D

@pedrommcarrasco
Copy link
Owner

Thank you @sgrandner ❤️

@hacker6284
Copy link

I think this is due to the fact that the Apple's Original Version is all of them put together in the same order and timing as at the beginning of the keynote they are taken from. It starts with unstable pipes, and then progresses through the rest in order. This is why it appears the timings are off. At least this is my undeerstanding.

@paulp1958
Copy link

Great screensaver mate can I get a copy of that for my phone ?

@pedrommcarrasco
Copy link
Owner

pedrommcarrasco commented Dec 8, 2019

Don’t think so 😕

@Mirror1Mirror
Copy link

I'm new to this can someone please tell me how to join this project and the most easiest part of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants