Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements needed :) #1

Open
gippy opened this issue May 22, 2019 · 0 comments
Open

Improvements needed :) #1

gippy opened this issue May 22, 2019 · 0 comments

Comments

@gippy
Copy link

gippy commented May 22, 2019

  1. Does not work with default input
    When you run it as anonymous user without changing anything it fails, because currency is not set.

  2. Currencies in input schema are not sorted (or at least pseudo sorted)
    Would be even better if you had currency codes and currency names as labels

  3. The log messages could be improved
    Currently most visible log messages are only "Saving home detail" which says absolutely nothing to the user, only that it does something.
    There should either be some ID (price range + listing number?) or title loaded from the page, so that user can see that it's loading different pages.

  4. Check out date label in input schema has a type "Check ut date"

  5. The default input has too many results, it shoudl idealy run for max 5 minutes, so that the user can see the results without having to abort it (or wasting all his free CU).

  6. The number inputs in input schema has no validation (at least they shoudl have minValue set to 0)

  7. Check in and check out dates should have pattern validation and expected date format in help text.

  8. Why is includeReviews required in the schema? You can just expect it to be false if it's not set.

  9. Why are you using Apify 13.3?

  10. This is just an option, maybe you can require the input schema and read the currencies from there, so that you have just once place with the large array.

  11. MIN_PRICE and MAX_PRICE could be renamed to DEFAULT_MIN_PRICE and DEFAULT_MAX_PRICE since they are not an actual limit, just default value. Default limit and offset could also be in constants.js

  12. You should validate that URLs provided to startUrls are actualy for airbnb.

  13. The readme should mention that startUrls and locationQuery are mutualy exclusive

And that is all from me, the code looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant