You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does not work with default input
When you run it as anonymous user without changing anything it fails, because currency is not set.
Currencies in input schema are not sorted (or at least pseudo sorted)
Would be even better if you had currency codes and currency names as labels
The log messages could be improved
Currently most visible log messages are only "Saving home detail" which says absolutely nothing to the user, only that it does something.
There should either be some ID (price range + listing number?) or title loaded from the page, so that user can see that it's loading different pages.
Check out date label in input schema has a type "Check ut date"
The default input has too many results, it shoudl idealy run for max 5 minutes, so that the user can see the results without having to abort it (or wasting all his free CU).
The number inputs in input schema has no validation (at least they shoudl have minValue set to 0)
Check in and check out dates should have pattern validation and expected date format in help text.
Why is includeReviews required in the schema? You can just expect it to be false if it's not set.
Why are you using Apify 13.3?
This is just an option, maybe you can require the input schema and read the currencies from there, so that you have just once place with the large array.
MIN_PRICE and MAX_PRICE could be renamed to DEFAULT_MIN_PRICE and DEFAULT_MAX_PRICE since they are not an actual limit, just default value. Default limit and offset could also be in constants.js
You should validate that URLs provided to startUrls are actualy for airbnb.
The readme should mention that startUrls and locationQuery are mutualy exclusive
And that is all from me, the code looks good.
The text was updated successfully, but these errors were encountered:
Does not work with default input
When you run it as anonymous user without changing anything it fails, because currency is not set.
Currencies in input schema are not sorted (or at least pseudo sorted)
Would be even better if you had currency codes and currency names as labels
The log messages could be improved
Currently most visible log messages are only "Saving home detail" which says absolutely nothing to the user, only that it does something.
There should either be some ID (price range + listing number?) or title loaded from the page, so that user can see that it's loading different pages.
Check out date label in input schema has a type "Check ut date"
The default input has too many results, it shoudl idealy run for max 5 minutes, so that the user can see the results without having to abort it (or wasting all his free CU).
The number inputs in input schema has no validation (at least they shoudl have minValue set to 0)
Check in and check out dates should have pattern validation and expected date format in help text.
Why is includeReviews required in the schema? You can just expect it to be false if it's not set.
Why are you using Apify 13.3?
This is just an option, maybe you can require the input schema and read the currencies from there, so that you have just once place with the large array.
MIN_PRICE and MAX_PRICE could be renamed to DEFAULT_MIN_PRICE and DEFAULT_MAX_PRICE since they are not an actual limit, just default value. Default limit and offset could also be in constants.js
You should validate that URLs provided to startUrls are actualy for airbnb.
The readme should mention that startUrls and locationQuery are mutualy exclusive
And that is all from me, the code looks good.
The text was updated successfully, but these errors were encountered: