Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need demo_gradle module? #169

Open
decebals opened this issue Sep 20, 2017 · 4 comments
Open

Do we need demo_gradle module? #169

decebals opened this issue Sep 20, 2017 · 4 comments
Labels

Comments

@decebals
Copy link
Member

decebals commented Sep 20, 2017

I prefer to eliminate demo_gradle module, to "merge" this module (build scripts and the kotlin part) with demo module.
The code in demo_gradle is redundant in my opinion.

@decebals decebals changed the title Do we need demo_gradle? Do we need demo_gradle module? Sep 20, 2017
@decebals
Copy link
Member Author

I don't use Gradle in my project and from this reason it's hard for me to maintain it (I admit that I don't know to much about Gradle).

@acesar
Copy link
Contributor

acesar commented Oct 21, 2017

@decebals I started using PF4J a couple of months ago and I am using Gradle, the demo was a big help for me.
I opened #177 to fix the demo and update PF4J to the latest version.
Please have a look.
(We can place it inside the demo folder)

@decebals
Copy link
Member Author

@acesar
Thanks for your contribution!
I don't realize yet if it's better to move the gradle scripts in demo directory and to remove demo_gradle.

@sschuberth
Copy link

I don't realize yet if it's better to move the gradle scripts in demo directory and to remove demo_gradle.

I'd definitely vote for having demo/maven and demo/gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants