-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent behavior of query method in Variable Elimination #683
Comments
@ankurankan What do you think should be the expected behavior? Shouldn't this return an empty dict for no variables specified? |
@ankurankan Yes, I agree with @yashu-seth . it should return an empty dictionary, because in case of variables not being an empty list we return marginal distrbution w.r.t that variable, so makes much sense to return a empty dict |
@ankurankan I also agree that it should return an empty dict when no variables specified .I want to work on this issue . What is your views on this? |
@lohani2280 Please go ahead. Should be a simple fix. |
…tion Now the query method returns an empty dict for no variables specified closes pgmpy#683
…tion Now the query method returns an empty dict for no variables specified closes pgmpy#683
Returns a set when
variables
isNone
. Otherwise returns adict
.The text was updated successfully, but these errors were encountered: