You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the photo-mosaic or photo-cards view: When photos are selected in the clipboard, clicking on the 'stack' button on a photo instead opens the regular view dialog, not showing the various photos in the stack.
2. How can we reproduce it?
Steps to reproduce the behavior:
Select any photo/video (circle in bottom right) to add it to the clipboard
Click the 'stack' icon on any photo while there are still photos in the clipboard
3. What behavior do you expect?
Since the icon and tooltip are for viewing the stack, I would expect the stack dialog, where I can go through the images in the stack. However, since I can't simply click an image to view it, due to the clipboard being populated, it would perhaps be better for the stack icon to change to the 'view' icon, and/or an additional button be present in order to choose between viewing image or viewing stack.
4. What could be the cause of your problem?
Misinforming icons/buttons when images are in the clipboard.
5. Can you provide us with example files for testing, error logs, or screenshots?
N/A
6. Which software versions do you use?
(a) PhotoPrism Architecture & Build Number: Photoprism Plus Build 231206-0935d9fab
(b) Database Type & Version: MariaDB
(c) Operating System Types & Versions: Linux (Unraid)
(d) Browser Types & Versions: Chrome
(e) Ad Blockers, Browser Plugins, and/or Firewall Software? Adguard
7. On what kind of device is PhotoPrism installed?
This is especially important if you are reporting a performance, import, or indexing issue. You can skip this if you're reporting a problem you found in our public demo, or if it's a completely unrelated issue, such as incorrect page layout.
Checking out the source more I see that it specifically sets 'showMerged' to false when there is a selection in the clipboard. Since not showing the stack is intended, my issue is more so that keeping the stack icon present in selectMode is misleading and results in Photoprism not behaving as a user would expect, given the icons and tooltips.
In this case, my suggestion would be to change the stack icon to "zoom_in" when in select mode. IMO best case would be to allow both options, but I understand that would likely require a greater refactoring of the onOpen functions.
Unfortunately I have no experience contributing to open source projects, nonetheless one the likes of Photoprism, so I'm not entirely comfortable moving forward with this myself 🫤
Thank you very much for your feedback. I agree that we should change the icon in selection mode.
To solve the problem that it is currently not possible to open all images of a stack while in selection mode, we have the following plans for the future:
We will develop our own photo viewer with the ability to view all photos of a stack.
However, neither of these are quick wins and we need to take care of some other tasks first.
graciousgrey
changed the title
Clicking stack button with photos in clipboard opens the 'view' dialog instead of the 'stack' dialog
UX: Show zoom icon rather than stack icon when in selection mode
May 11, 2024
1. What is not working as documented?
In the photo-mosaic or photo-cards view: When photos are selected in the clipboard, clicking on the 'stack' button on a photo instead opens the regular view dialog, not showing the various photos in the stack.
2. How can we reproduce it?
Steps to reproduce the behavior:
3. What behavior do you expect?
Since the icon and tooltip are for viewing the stack, I would expect the stack dialog, where I can go through the images in the stack. However, since I can't simply click an image to view it, due to the clipboard being populated, it would perhaps be better for the stack icon to change to the 'view' icon, and/or an additional button be present in order to choose between viewing image or viewing stack.
4. What could be the cause of your problem?
Misinforming icons/buttons when images are in the clipboard.
5. Can you provide us with example files for testing, error logs, or screenshots?
N/A
6. Which software versions do you use?
(a) PhotoPrism Architecture & Build Number: Photoprism Plus Build 231206-0935d9fab
(b) Database Type & Version: MariaDB
(c) Operating System Types & Versions: Linux (Unraid)
(d) Browser Types & Versions: Chrome
(e) Ad Blockers, Browser Plugins, and/or Firewall Software? Adguard
7. On what kind of device is PhotoPrism installed?
This is especially important if you are reporting a performance, import, or indexing issue. You can skip this if you're reporting a problem you found in our public demo, or if it's a completely unrelated issue, such as incorrect page layout.
(a) Device / Processor Type: Unraud OS, Ryzen 2700
(b) Physical Memory & Swap Space in GB: 32GB
(c) Storage Type: HDD, SSD, RAID, USB, Network Storage,...: Installed on SSD, storage on HDD
8. Do you use a Reverse Proxy, Firewall, VPN, or CDN?
NGINX Proxy Manager, version 2.9.16
The text was updated successfully, but these errors were encountered: