Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb validation fails due to rewritten URL #46

Open
teebling opened this issue Apr 2, 2021 · 1 comment
Open

Breadcrumb validation fails due to rewritten URL #46

teebling opened this issue Apr 2, 2021 · 1 comment
Labels

Comments

@teebling
Copy link

teebling commented Apr 2, 2021

Describe the bug :

In functions_display.php, phpBB builds the navigation links used in the breadcrumbs submenu. These breadcrumbs validate properly in both Google's Structured Data testing tool and Google's Rich Results Test tool when this extension is disabled.

However, when USU is enabled something goes wrong because the breadcrumbs microdata generated by functions_display.php is still based on URLs having forum ID in them.

When virtual folders are used to rewrite forum URLs (for example for example mydomain.com/myforum/) the forum ID is stripped, meaning that the microdata that is generated is incorrect and the 'item' field is not preprocessed, therefore the markup fails validation.

Is there any way we could stop this URL from being preprocessed by USU so that the breadcrumbs will actually work again?

@teebling teebling added the bug label Apr 2, 2021
@teebling
Copy link
Author

teebling commented Apr 2, 2021

Fixed this by removing the append_sid function from the relevant parts of functions_display.php and replacing it with a manually constructed URL, because I guess that's what USU targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant