Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with newer cart versions (>8) #82

Closed
wants to merge 1 commit into from

Conversation

hrobeers
Copy link
Contributor

@hrobeers hrobeers commented May 17, 2019

Version numbers are incremented with PICO-8 builds, but no file format changes have been made so far, version checking seems irrelevant.

This fixes #77

To make most carts work, more changes are required, see my other PRs.
Or my workarounds branch: https://github.com/hrobeers/picolove/tree/workarounds

…t changes have been made so far, version checking seems irrelevant
@gingerbeardman
Copy link
Contributor

In early versions new commands were added. Some commands were renamed and even removed.

@hrobeers
Copy link
Contributor Author

Interesting.
But I don't think refusing to even try running a game is a good approach for this experimental piece of software. Wouldn't it be better to just crash on some incompatible games?
Many carts out there have versions >8 and many run fine after some minor patching (ref. my workarounds branch)

@gingerbeardman
Copy link
Contributor

I have no preference either way, I was just pointing out that there were changes in the command set which I guess is why the version tag is used by pico8 itself

@Shoozza
Copy link
Member

Shoozza commented May 18, 2019

I'll make it a note instead of an error since we might miss some functionality available in later cart versions.

@Shoozza Shoozza closed this in a270e4a May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load carts that are version > 8
3 participants