New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: use static expression context to calculate the TTL expire time #53104
Conversation
Hi @lcwangchao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fab619c
to
0007b78
Compare
0007b78
to
c2854a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53104 +/- ##
================================================
+ Coverage 72.0377% 74.3393% +2.3016%
================================================
Files 1499 1509 +10
Lines 431246 441470 +10224
================================================
+ Hits 310660 328186 +17526
+ Misses 101286 93079 -8207
- Partials 19300 20205 +905
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #53103
Problem Summary:
After we introduced
StaticExprContext
, we can build and evaluate an expression more simply without relying on the session. So, we can make it simple to evalute a TTL expire time.What changed and how does it work?
EvalExpireTime
to compute the TTL expire time. It only requires the current time and the expression info as the input argument. So it is more simple, the new function is:EvalExpireTime
to check whether a expire expression is legal.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.