New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: skip empty partition table to merge global stats #53162
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53162 +/- ##
================================================
+ Coverage 72.4329% 74.5512% +2.1183%
================================================
Files 1491 1492 +1
Lines 428997 433506 +4509
================================================
+ Hits 310735 323184 +12449
+ Misses 99002 90411 -8591
- Partials 19260 19911 +651
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
8c3a61d
to
9483842
Compare
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #53164
Problem Summary:
What changed and how does it work?
Now, we analyze empty partition tables. analyze will trigger the merge global stats for the empty partition table. it takes too much time and it is unnecessary. we need to skip the merge global stats with the empty partition table.
We will check the process row after the analyze jobs. if the process row is empty, we will skip the merge global stats.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.