-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is a 2%-4% performance regression in sysbench select_random_points #51898
Comments
/type performance |
/remove-label may-affects-7.5 |
In the new CPU profile, we can see that there is additional CPU overhead in the index usage reporter section. This overhead was introduced by commit 7087f70. |
Change the sig label to sig/sql-infra |
/remove-severity critical |
/remove-label may-affects-7.5 |
Tracing back to this PR will lead to regression in the following three benchmarks: BenchmarkBatchPointGet, BenchmarkPreparedPointGet, and BenchmarkPointGet. https://github.com/pingcap/tidb/blob/master/Makefile#L299 |
To re-produce this issue, I wrote a simpler implementation of For the commit with index usage, the average QPS (after enough warm-up, though I don't know why warm-up does help) is 58393, and the commit without index usage is 59029. The degradation is around 1.07%. (Also, I don't know why this go-version is a little bit slower than the lua version, maybe the go client is not as fast as the driver used by sysbench). I have had some ideas to boost the performance of index usage a little. See #53195 |
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
2. What did you expect to see? (Required)
No performance regression
3. What did you see instead (Required)
2424-01-30, QPS= 62463 , commit 25f44f5
2424-01-31, QPS= 59776 , commit 27fbccb
4. What is your TiDB version? (Required)
The text was updated successfully, but these errors were encountered: