Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crew for Hire BBS ad doesn't dynamically spawn #5510

Open
antonspace opened this issue Jan 31, 2023 · 2 comments · May be fixed by #5596
Open

Crew for Hire BBS ad doesn't dynamically spawn #5510

antonspace opened this issue Jan 31, 2023 · 2 comments · May be fixed by #5596

Comments

@antonspace
Copy link

Observed behaviour

Decided to trade in the Sinotrix, and buy a Skipjack. In order to use the Skipjack, another crew member was required, the bulletin board at this station had no crew for hire, and despite it being a busy station, no amount of fast forwarding seems to populate the empty crew for hire advert (3 months)

Steps to reproduce

Load the savegame, buy the skipjack, and head over to the bulletin board, fast forward...
sinonatrix19.gz

Another unrelated issue here is that if the player stays on the bulletin board while fast forwarding, missions enter negative territory time-wise, clicking on the crew for hire, or another tab clears these negative timestamps, but clicking a mission with a negative timestamp, or saving the game when negative timestamps exist will cause a crash, or produce a save that is unloadable. If this issue is not known I will open a fresh issue for this?

My pioneer version (and OS):
Latest code.
Linnux Mint
Screenshot_2023-01-31_12-26-59
Screenshot_2023-01-31_13-03-52
@antonspace
Copy link
Author

Even stranger, click on the personal information, then click on the crew roster, then more info, 2 different people, yet the ship only has one crew??

@impaktor
Copy link
Member

Each module is responsible for implementing it's own onUpdateBBS, e.g. package delivery removes outdated adverts, and adds one new every hour (on average)

Crew contract module does not implement any onUpdateBBS, thus, is only run when BBS is created (when you land at a station).

missions enter negative territory time-wise, clicking on the crew for hire, or another tab clears these negative timestamps, but clicking a mission with a negative timestamp, or saving the game when negative timestamps exist will cause a crash

Please do

@Web-eWorks Web-eWorks changed the title Crew for hire issue. Crew for Hire BBS ad doesn't dynamically spawn Feb 1, 2023
@zonkmachine zonkmachine linked a pull request Jul 15, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CrewContracts - onUpdateBB zonkmachine/pioneer
2 participants
@impaktor @antonspace