New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user and a developer, I want to display Japanese characters in charts #760
Comments
@kyokonishito can you confirm this is specifically when using the |
@DTAIEB i believe the issue is with the default font used by matplotlib does not support Japanese, Chinese, etc characters: we could:
my vote would be for 2 but this would leave it up to the user to make sure they have the preferred font already installed in their system and know the name so it can be passed in |
@vabarbosa I confirmed
|
@kyokonishito as i think about this more i am wondering if it is best to keep with pixiedust convention and put the with either case, i think we should probably also store the i want to wait for feedback from @DTAIEB before committing any changes. however, in the meantime you can use try using my working branch which has a temporary fix to keep you from being blocked:
and you should see characters displayed properly: |
@vabarbosa Thank you! I tried your working branch. It works fine.
|
@vabarbosa Yes I agree with #2. To make it easier, perhaps we could also have a drop down contextual option to let users pick from some of the most common fonts. |
@vabarbosa (the error about a String variable is still occurred) |
@kyokonishito i will keep posted, but yes feel free to use the temporary fix in my branch in the meantime. |
@vabarbosa Thanks! I will introduce your my working branch as a temporary fix in my session. |
As a user and a developer, I want to display Japanese characters in charts
Expected behavior
Actual behavior
Steps to reproduce the behavior
import pixiedust
import pandas as pd
df = pd.DataFrame([["四月", 26],["May", 10],["June", 5]], columns=['key', 'value'])
display(df)
The text was updated successfully, but these errors were encountered: