Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/multi set props #2856

Merged
merged 7 commits into from May 15, 2024
Merged

Fix/multi set props #2856

merged 7 commits into from May 15, 2024

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented May 10, 2024

Fix #2852

@T4rk1n T4rk1n requested review from emilykl and gvwilson May 13, 2024 15:06
gvwilson
gvwilson requested changes May 13, 2024
View reviewed changes
Copy link

@gvwilson gvwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about {**updates, **props} - if I'm misunderstanding what it's doing, please let me know.

dash/_callback_context.py Outdated Show resolved Hide resolved
dash/long_callback/_proxy_set_props.py Show resolved Hide resolved
tests/integration/callbacks/test_arbitrary_callbacks.py Show resolved Hide resolved
@T4rk1n T4rk1n merged commit 993b57f into dev May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvwilson gvwilson gvwilson approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@emilykl emilykl Awaiting requested review from emilykl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] set_props called multiple times only keep the last props.
2 participants
@T4rk1n @gvwilson