-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: List all properties returned by Graph when using m365 aad user list
#4667
Comments
Great suggestion @ValerasNarbutas. To me it doesn't make much sense that we aren't returning all properties we retrieve from Graph. |
totally agree, this is my first command example.. i have to do 2 examples as per requirement :D. A default return would be just enough. |
Yes that's because you used a So for this enhancement, I don't think we need extra examples since we are only extending something that already exist. |
ahh, thanks @milanholemans , i will do this next time! |
I've trimmed down your issue a bit (removed the unnecessary sections). If this looks good for you, we can start implementing it. |
m365 aad user list
nothing to add, thanks @milanholemans |
Just to give some extra context, this is not a breaking change because we will just enrich the output with extra properties that are returned by default by Graph. The already existing properties will still be there. |
Nice enhancement @ValerasNarbutas! It's indeed more logical that the command would return all the available properties instead of trimming it. Do you want to work on this issue? |
with pleasure :) @Jwaegebaert |
Awesome! The issue is all yours 🚀 |
One small tip: when contributing to GitHub repositories like ours, the best strategy is that you create a new git branch based on your main branch, for each issue you are working on, and put your contributions for that specific issue in there. That makes sure that all your contributions are isolated on a specific branch and your main branch remains untouched (as it should be because this one should be in sync with our main). Currently you cannot do this because you already made a PR with changes on your main branch. But keep this in mind for the future. |
this is exactly tip i needed !! @milanholemans i had it somewhere back in my mind, but never tried :) |
Hey @ValerasNarbutas, just checking in. How is everything going regarding this issue? |
Resetting due to lack of response |
Can I work on this? |
@MathijsVerbeeck note that this might interfere with #5644 |
I'll wait for the merge of Nandeeps' PR and work on this afterwards. |
Idea
Currently this command "m365 aad user list" return only userprincipalname and display name, would be great if it could return same number properties as graph API does by default.
Additional Info
one suggestion:
from @Adam-it
we could just modify this
cli-microsoft365/src/m365/aad/commands/user/user-list.ts
Lines 57 to 59 in f8f3553
not to trim to ['userPrincipalName', 'displayName'];
The text was updated successfully, but these errors were encountered: