Feat/add jsonschema json option #3327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a value for it is given, it is validated against the Draft7 meta schema in the JsonOptions Validate function. In the checkJsonValue function, if a JsonSchema option was selected, the JSON is validated against the given jsonschema, and the appropriate errors are returned in case of a validation error
…h-tekuri/jsonschema, which supports newer jsonschema versions as well as having better error formatting and performance
…of empty json objects
…ainst the JSON schema in the checkJsonValue function. Also fixed JsonSchema validation in the scenario where there is an empty JsonOptions object. Updated unit test accordingly
|
Thank you, but I'm not sure about the suggested implementation and I'll close the PR for now. The linked task remains with a very low priority (see also #3271). Couple things that I wish eventually to tackle if this ended up getting merged:
|
|
Thank you very much for your time. As for the two things you mentioned:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to validate JSON fields with a given JSON schema option.
This is done by adding JsonSchema as an optional string field in
schema.JsonOptionsand validating the JSON value with the JSON schema in thevalidators.checkJsonValuecheck.The JSON schema validation was written using the https://pkg.go.dev/github.com/santhosh-tekuri/jsonschema/v5 library, which leads the line in terms of performance and correctness of GO JSON schema validator libraries, as can be seen here: https://dev.to/vearutop/benchmarking-correctness-and-performance-of-go-json-schema-validators-3247. It also supports the latest meta-schema (Draft 2020-12), which is used in the
checkJsonSchemafunction to validate a given JSON schema.Closes #1154.