Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child node type 'geo' not found for node '/'. Available types are: , obj, root #49

Open
kungfooman opened this issue Aug 6, 2022 · 5 comments

Comments

@kungfooman
Copy link

I tried the first snipped in the README.md and it doesn't work:

child node type 'geo' not found for node '/'. Available types are: , obj, root

Screen:

image

Sourcemap also doesn't seem to load.

@kungfooman
Copy link
Author

2nd example is also broken:

image

If you want people to test it out, make at least the examples work 😅

@frading
Copy link
Collaborator

frading commented Aug 6, 2022

hey @kungfooman thanks a lot for the heads up, really appreciate. Will fix those shortly.

@frading
Copy link
Collaborator

frading commented Aug 6, 2022

@kungfooman I've just updated the readme. I should absolutely have kept those up to date, so thanks a lot again for letting me know.

That said, I plan to remove those 2 examples, as they're not representative on how I recommend to use polygonjs. Using it with the visual editor (either on https://polygonjs.com, or via the npm module npx polygonjs-editor) has many more benefits, the main one being that it will auto generate the imports for you, keeping the bundle size to a minimum.

But those examples are still good to get a sense of the api needed to go beyond what the editor can do. So I'll probably move them in the docs, under the api section.

Don't hesitate if you spot anything else, I'll do my best to help.

@frading frading closed this as completed Aug 8, 2022
@kungfooman
Copy link
Author

Thank you for fixing, its still missing a <div id="app"></div> and if you forget about it, the engine doesn't warn about anything, which it probably should.

@frading frading reopened this Aug 9, 2022
@frading
Copy link
Collaborator

frading commented Aug 9, 2022

oh I see. Yes, you're right.
At the moment, there is no warning since it's possible to create the viewer without mounting it, but that doesn't seem quite right if the element option is given. I'll have a think, I may indeed just add the html you mention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants