Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-AMP: skip not working #315

Open
willpower232 opened this issue Aug 14, 2017 · 5 comments
Open

X-AMP: skip not working #315

willpower232 opened this issue Aug 14, 2017 · 5 comments
Labels

Comments

@willpower232
Copy link
Collaborator

As per https://github.com/atech/postal/wiki/Click-&-Open-Tracking#disable-tracking-on-a-per-e-mail-basis I included the header in an email to ignore click tracking in that message.

Unfortunately, it does not seem to have done anything.

Having a quick look in the code, I can see that that header is only checked here https://github.com/atech/postal/blob/6f29bc8d3f6f197d142724a7baee7376ff5fe8aa/lib/postal/message_db/message.rb#L548

Is the wiki wrong or is my understanding flawed?

The +notrack code worked perfectly.

@willpower232
Copy link
Collaborator Author

Slightly related, I think that if this header should block click tracking on a message, it should be added to the password reset email in postal.

Adding +notrack would not be appropriate if someone is not using postal to send the internal emails so the header would be the best solution.

@hadifarnoud
Copy link

hadifarnoud commented Nov 10, 2019

any update on this? still have this issue

@willpower232
Copy link
Collaborator Author

I was kinda waiting for comment from atech or someone more knowledgeable but alas it was not the case.

@hadifarnoud
Copy link

Even with the latest update, we still have this issue. do you know how to fix this?

@Electromaster232
Copy link

Is this still an issue for others? I'm seeing this exact problem. I've verified through the Postal UI that the X-AMP: skip header is making it through, but Postal is not disabling the tracking for that message as a result of the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants