Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScoreInfo.Passed should be deprecated in favour of F rank #27864

Open
frenzibyte opened this issue Apr 14, 2024 · 3 comments · May be fixed by #28057
Open

ScoreInfo.Passed should be deprecated in favour of F rank #27864

frenzibyte opened this issue Apr 14, 2024 · 3 comments · May be fixed by #28057
Assignees
@frenzibyte
Labels
area:scoring type:code-quality

Comments

@frenzibyte
Copy link
Member

frenzibyte commented Apr 14, 2024 •
edited

Opening an issue thread because I was concerned whether to use Passed or Rank == F. It's used in little places, and I would've directly opened a PR to remove it, but it gets sent to the servers via SoloScoreInfo so I'm not willing to touch it.
@bdach
Copy link
Collaborator

bdach commented Apr 15, 2024

Between this and #27865 I'm very confused as to what you're trying to go for here? You want to encode the passed flag into the replay but also deprecate it? How does that make any sense?

@peppy
Copy link
Sponsor Member

peppy commented Apr 15, 2024

Seems the flag can be nuked as we have moved to using F rank. You'd need to attempt to remove it and see if anything breaks (on a quick look it doesn't seem anything would).

I don't think this needs discussion.

@frenzibyte frenzibyte mentioned this issue Apr 18, 2024
Open
@frenzibyte
Copy link
Member Author

Between this and #27865 I'm very confused as to what you're trying to go for here? You want to encode the passed flag into the replay but also deprecate it? How does that make any sense?

Summarised discussion of this and reply in #27865 (comment).

@frenzibyte frenzibyte linked a pull request May 1, 2024 that will close this issue
Open
1 task
@frenzibyte frenzibyte self-assigned this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frenzibyte frenzibyte

Labels
area:scoring type:code-quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Passed flag from score classes frenzibyte/osu
3 participants
@peppy @bdach @frenzibyte