Issue 7280: Prohibit use of default thread pool #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Tests don't need javadocs Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Add in suppressions for existing errors Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Wrap overly long lines Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Disable the use of volitile Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Remove unneeded volatile declarations Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Prevent static atomic references Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Disallow sleeping in unit tests. Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Issue 7110: Need a command to remove table keys from Admin CLI (pravega#7115) Issue 7110: Admin CLI command to remove table keys (pravega#7115) Signed-off-by: Ankur_Anand <Ankur.Anand@dell.com> Issue 7143 : Add more logs in read path in client. (pravega#7142) Issue 7143 : Add more logs for read path in client. Signed-off-by: Bhupender-Y <Bhupender.Y@dell.com> Allow Pravega operator to include AdminCLI port 9999 in SegmentStore Service (pravega#7174) Allow Pravega operator to include AdminCLI port 9999 in SegmentStore Service Signed-off-by: Amit-Singh40 <amit.singh30@dell.com> Issue 7137: Need a command to get the container Id for a given segment name (pravega#7170) Issue 7137: Adding a new admin cli command, which will give the container Id which is owning the segment. Signed-off-by: Prajna_U <prajna.u1@dell.com> [issue 7133] Add timeout option in getThrowingExceptions() Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] solved style issue Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [issue 7133] Added unit test for getThrowingExceptionWithTimeout() Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [issue 7133] Added unit test for getThrowingExceptionWithTimeout() Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> fix check style error Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> fix check style errors Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Increase code coverage Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issu 7133 Added config and new constructor for the client config Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] removing unusual changes done in the last commit Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Added unit test for testing if timeout exception is thrown. Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Added Param for timeout exception Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] fixing the testThrowing exception unit test Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Clean code Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] clean Code and fix style Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Added unit test for throwing servertimeoutexception. Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Added unit test for write method for servertimeout exception Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Added comments in test Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Added comments in test Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Resolving comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Resolving comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] resolving the review comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] resolving comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] resolving comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] resolving comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] resolving comments Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Reverted SegmentOutStreamImpl changes Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Reverted SegmentOutStreamImpl changes Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Reverted SegmentOutStreamImpl changes Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> [Issue 7133] Reverted SegmentOutStreamImpl changes Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Issue 7133: Add doc comments in client config Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Issue 7147: New client API to cancel all outstanding checkpoints (pravega#7180) Adding a new client API, which will cancel all outstanding checkpoints. Signed-off-by: Prajna_U <prajna.u1@dell.com> Issue 7188: Ensure token expired notification reaches client. (pravega#7189) Ensure token expired notification reaches client. Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Issue 7118: Add reply WireCommands to DEBUG log. (pravega#7119) Add reply WireCommands to DEBUG log. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com> Issue 7209: Makes Connect Timeout configurable for system test (pravega#7211) solve the timeout issue happening with failover system test. This PR changes following Make ConnectTimout Configurable for system test Set 2 minute timeout for all the system test Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Issue 7213: Handle lock transfer in case of unreliable network (pravega#7216) Handle lock transfer in case of unreliable network Signed-off-by: Shashwat Sharma <shashwat_sharma@dell.com> Issue 7194: Add timeout to SetupAppend and Provide initial delay option to retry (pravega#7231) Adds a timeout (default 30sec) to setting up a connection Provide a initial delay option to retry class --------- Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Issue 7248: Recover from truncation in state synchronizer (pravega#7074) When state synchronizer is initialized, attempt to recover if a truncation has occurred. Optimize the init path to avoid a getSegmentInfo call. Avoid reinitializing a compacted state. Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Issue 7258: Handling evicted operations before flushing to storage. (pravega#7251) Issue 7258: Handling operations of evicted segments before flushing to storage. (pravega#7251) --------- Signed-off-by: dada-dell-emc <dadasaheb.patil@dell.com> Signed-off-by: Abhin Balur <Abhin_Balur@dell.com> Co-authored-by: Abhin Balur <Abhin_Balur@dell.com> Co-authored-by: abhinb <88840194+abhinb@users.noreply.github.com> Feature LTS-based recovery (pravega#7244) Issue 7243: Ability to recover a cluster from saved LTS state. Introduces the ability in a Segment Store container to recover off the data present in Storage. Signed-off-by: Sachin Joshi <sachin.joshi@emc.com> Signed-off-by: Amit-Singh40 <amit.singh30@dell.com> Signed-off-by: a6dulaleem <abdul.aleem1@dell.com> Signed-off-by: Ankur_Anand <Ankur.Anand@dell.com> Signed-off-by: Kuldeep Kumar <kuldeep.kumar3@dell.com> Signed-off-by: Abhin Balur <Abhin_Balur@dell.com> Implement PDP-55: Support for reading in fixed size batches. (pravega#7230) Implement support for incremental batch reads per PDP-55 Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> --------- Signed-off-by: AnjuDas <anju.das@dell.com> Signed-off-by: Ankur_Anand <Ankur.Anand@dell.com> Signed-off-by: amit-kumar59 <amit.kumar59@dell.com> Signed-off-by: Bhupender-Y <Bhupender.Y@dell.com> Signed-off-by: Munish <munish.kumar2@dell.com> Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com> Signed-off-by: Shwetha N <shwetha.n1@dell.com> Co-authored-by: anju-c-das <107111390+anju-c-das@users.noreply.github.com> Co-authored-by: Bhupender Singh Yadav <93965228+Bhupender-Y@users.noreply.github.com> Co-authored-by: AnkurAnand11 <122247323+AnkurAnand11@users.noreply.github.com> Co-authored-by: amit-kumar59 <114211139+amit-kumar59@users.noreply.github.com> Co-authored-by: Bhupender-Y <Bhupender.Y@dell.com> Co-authored-by: Munish <munish.kumar2@dell.com> Co-authored-by: Ankur_Anand <Ankur.Anand@dell.com> Co-authored-by: AnjuDas <anju.das@dell.com> Co-authored-by: Shwetha N <shwetha.n1@dell.com> Issue 7264: Fix for admin cli port (pravega#7265) Fix for Admin CLI port with externalAccessEnabled. Signed-off-by: Abhin Balur <Abhin_Balur@dell.com> Issue 8043: Client application stuck at initiateCheckpoint Api call (pravega#7260) Issue 8043: Client application stuck at initiateCheckpoint Api call --------- Signed-off-by: Shwetha N <shwetha.n1@dell.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
tkaitchuck
force-pushed
the
checkstyle-2
branch
from
0478869
to
6fb1efe
Compare
tkaitchuck
changed the title
anishakj
reviewed
Sep 25, 2023
anishakj
suggested changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Adds a checkstyle restriction to prohibit the use of the default thread pool
Purpose of the change
Fixes #7280
What the code does
Prohibits using the single argument versions of the "*Async" methods on completable future.