Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Closing textboxes overlapping tiles $80+ glitches out for a frame #1102

Open
Rangi42 opened this issue Jan 1, 2024 · 3 comments
Open
Labels

Comments

@Rangi42
Copy link
Member

Rangi42 commented Jan 1, 2024

The overworld engine puts tiles $80-$FF in VRAM bank 1. When a textbox is overlapping them and it closes, there can be a one-frame flash of glitches tiles as the VRAM is updated. Setting a breakpoint on call _OpenAndCloseMenu_HDMATransferTilemapAndAttrmap can help notice it, as reported by NickJam.

image

image

@mid-kid
Copy link
Member

mid-kid commented Jan 3, 2024

Can this even be fixed without a significant refactor to the way tiles are updated?

@Rangi42
Copy link
Member Author

Rangi42 commented Jan 3, 2024

"Fix: Refactor how tiles are updated to avoid this." or "No fix exists yet" are still valid ways to document that the bug exists.

@xCrystal
Copy link
Member

xCrystal commented Jan 10, 2024

You can avoid this by overlaying the window (which is using the tilemap with no text tiles) during the transition, by writing $00 to hWY either just before or just after the call to OverworldTextModeSwitch (depending on if you want the text to last an extra frame or not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants