Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript dependency #47

Open
ryanb opened this issue Sep 28, 2021 · 2 comments · May be fixed by #48
Open

TypeScript dependency #47

ryanb opened this issue Sep 28, 2021 · 2 comments · May be fixed by #48

Comments

@ryanb
Copy link

ryanb commented Sep 28, 2021

This looks like a great little date/time picker, but is it possible to move TypeScript into the dev dependencies? When installing through npm it adds typescript to my project which includes a lot of other dependencies.

If I'm importing the js/css files from the dist folder then I don't see why I need TypeScript.
@priyank-p
Copy link
Owner

@ryanb Can you please do a quick PR with that change?

@ryanb ryanb linked a pull request Sep 29, 2021 that will close this issue
Open
@ryanb
Copy link
Author

ryanb commented Sep 29, 2021

@priyank-p sure! Done here: #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move TypeScript into devDependencies ryanb/simplepicker
2 participants
@ryanb @priyank-p