Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy Route Testing tool compatibility for Contour #6268

Open
clayton-gonsalves opened this issue Mar 13, 2024 · 1 comment · May be fixed by #6306
Open

Envoy Route Testing tool compatibility for Contour #6268

clayton-gonsalves opened this issue Mar 13, 2024 · 1 comment · May be fixed by #6306
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.

Comments

@clayton-gonsalves
Copy link
Contributor

Envoy provides a route testing tool through which you can test routing logic.
Reference: https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/tools/router_check#config-tools-router-check-tool

This tool is run against raw envoy route configs.

it would be helpful for the community if contour could generate raw routing rules(given an HTTPProxy/ingress/gateway and services) to be tested against this tool.

This tool can be useful in dev workflows, ci tests etc.

@clayton-gonsalves clayton-gonsalves added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Mar 13, 2024
@clayton-gonsalves clayton-gonsalves self-assigned this Mar 13, 2024
@clayton-gonsalves clayton-gonsalves linked a pull request Mar 25, 2024 that will close this issue
@sunjayBhatia
Copy link
Member

Just took a look at the first PR for this and it looks great overall, probably just some minor comments to come

I think we'll probably want to add a few tasks to this issue to complete before calling it fully done:

  • since cluster name readability is an issue, IMO to have confidence the routegen tool generated what is being tested, we should add the k8s Service namespace/name to the cluster metadata, similar to how we add the originating configuration kind and namespace/name to routes
  • add Gateway API resource support/testing
  • add Ingress testing
  • add an e2e test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants