Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per IP rate limit? #6411

Open
sabershahhoseini opened this issue May 6, 2024 · 2 comments
Open

Per IP rate limit? #6411

sabershahhoseini opened this issue May 6, 2024 · 2 comments
Labels
kind/question Categorizes an issue as a user question.

Comments

@sabershahhoseini
Copy link

Is there any way to apply per IP rate limit? Seems like local rate limits do not care about IP and only thing is they care is how many requests are given to upstream service.

I mean, if someone just bulk requests to my service, anyone else gets 429? It's not good!

@sabershahhoseini sabershahhoseini added kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Hey @sabershahhoseini! Thanks for opening your first issue. We appreciate your contribution and welcome you to our community! We are glad to have you here and to have your input on Contour. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@sunjayBhatia
Copy link
Member

Is there any way to apply per IP rate limit? Seems like local rate limits do not care about IP and only thing is they care is how many requests are given to upstream service.

Envoy's local rate limit filter does not offer more advanced mechanisms for filtering requests or applying different requests based on source IP

this can be achieved using global rate limiting and using the request source IP in a descriptor that the rate limit server applies a specialized rate limit for, see: https://projectcontour.io/docs/1.28/config/rate-limiting/#global-rate-limiting

@sunjayBhatia sunjayBhatia removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Categorizes an issue as a user question.
Projects
None yet
Development

No branches or pull requests

2 participants