Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Spacing between numbers in modal #244

Closed
Codehagen opened this issue May 14, 2024 · 9 comments · Fixed by #246
Closed

Feature: Spacing between numbers in modal #244

Codehagen opened this issue May 14, 2024 · 9 comments · Fixed by #246
Labels
👀 Exploration Pending 💡 feature Requests for new features or enhancements.

Comments

@Codehagen
Copy link
Member

Codehagen commented May 14, 2024 •
edited

Feature Request

Type: 💡 Feature

Current Behavior:
Currently, the modal does not format numbers correctly. When you enter a number like 123456789, it displays without any spaces. We need it to display as 123 456 789.

Steps to Reproduce:

  1. Go to /dashboard
  2. Click on Add Asset
  3. Click on Add Account
  4. Observe the number formatting issue as shown in the screenshot:

Screenshot 2024-05-14@2x

Suggested Solution:
Modify the input fields for numbers to automatically insert spaces between every thousand. Ensure that these spaces are removed when the value is processed as a number.

Additional Context:
No response
@Codehagen Codehagen added 💡 feature Requests for new features or enhancements. 👀 Exploration Pending labels May 14, 2024
@linear Linear
Copy link

linear bot commented May 14, 2024

BAD-45 Feature: Spacing between numbers in modal

@Amirthananth
Copy link
Contributor

.take

@Codehagen
Copy link
Member Author

Hi @Amirthananth - A person on discord is working on this. New person that wanted to try this one. Can fix a new issue.

@Amirthananth
Copy link
Contributor

Hey @Codehagen that person is me :) the name is different on discord and GitHub that's why the confusion 😅

@Codehagen
Copy link
Member Author

Ahh! No worries. Then go for it 😁. The person who made this is going to review it after to see ⚡

@Amirthananth
Copy link
Contributor

@Codehagen I was wondering if we should space as the separator or comma as a separator ?

@Codehagen
Copy link
Member Author

I think space is best. Since some countries have comma and some had dots. With spaceing they cant argue 😅

@Amirthananth
Copy link
Contributor

That sounds fair. We should go for spaces if we want to keep it generic. If we want to be specific to a region then maybe we can go for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString#

@ousszizou
Copy link
Contributor

Ahh! No worries. Then go for it 😁. The person who made this is going to review it after to see ⚡

@Codehagen For sure!

@Amirthananth Amirthananth mentioned this issue May 15, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👀 Exploration Pending 💡 feature Requests for new features or enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Spacing between numbers in modal Amirthananth/Badget
3 participants
@Amirthananth @Codehagen @ousszizou