Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Editor not updating on some important Scene tree events #50

Open
BryceBubbles opened this issue May 18, 2020 · 1 comment
Open
Labels
bug Something isn't working enhancement New feature or request

Comments

@BryceBubbles
Copy link

If you add a new ConceptGraph node to the scene, and then you delete it, undo, or click another ConceptGraph node, the Load/Create buttons don't disappear from the Graph Editor. This stops interaction with other graphs. This is the main issue!

If a ConceptGraph node with a graph loaded is removed from the scene (delete or undo), the graph still shows in the Graph Editor, until you add or click on another ConceptGraph node. Not a big issue.

Moving between Scene tree nodes with keyboard arrows doesn't update the Concept Graph Editor when ConceptGraph nodes are highlighted. Note sure if it should or not, but probably.

Click a ConceptGraph node in one scene, then click a non-ConceptGraph node, then switch to another scene. When switching back the Graph Editor now says "Select a ConceptGraph node". It would be nice if it kept showing the last selected Graph for that scene. Might be tricky / impossible?

@HungryProton
Copy link
Member

Latest commit in master ead7fac should have fixed the two first issues.

Moving with the keyboard arrow is strange because it doesn't seem to trigger a selection_changed event, but the inspector still reacts to this ... I need to check in Godot sources what's going on.

Switching on a scene and remembering what was the last selected Graph should be possible. I think there's some code to add in concept_graph_plugin.gd to handle this, I'll see what I can do

@HungryProton HungryProton added bug Something isn't working enhancement New feature or request labels May 28, 2020
@HungryProton HungryProton added this to the 0.5 release milestone Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants