Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_image validation prevents local images #5101

Open
3 tasks done
danny6167 opened this issue May 16, 2024 · 4 comments · Fixed by #5103
Open
3 tasks done

docker_image validation prevents local images #5101

danny6167 opened this issue May 16, 2024 · 4 comments · Fixed by #5103
Assignees
Labels
bug Something that's not working as it's intended to be.

Comments

@danny6167
Copy link
Member

Current Behavior

"The image format is invalid." error is received when attempting to use an image starting with ~ (local image)

Expected Behavior

Image names beginning with ~ should be accepted

Steps to Reproduce

Enter a docker image starting with ~

Panel Version

1.11.7

Wings Version

N/A

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
@danny6167 danny6167 added the bug Something that's not working as it's intended to be. label May 16, 2024
@danny6167 danny6167 self-assigned this May 16, 2024
@QuintenQVD0
Copy link
Contributor

If you build a local image with the -t flag it still works as you can then just use dev:latest?

@stive101
Copy link

stive101 commented May 17, 2024

with quintens soution it will work, u need to tag dev:latest to your image, and after that dev:latest is your new image name,
with that u can start you custom image, thanks again Quinten, i try to figure out what i can do here for hours now ;=)

@danny6167
Copy link
Member Author

Yeah it still needs to be fixed though as this isn't going to work for all cases.

I'll submit a fix in a few hours.

@danny6167
Copy link
Member Author

I've submitted a PR.
If you need to fix this before the next release you can apply the patch as such

cd /var/www/pterodactyl
curl https://patch-diff.githubusercontent.com/raw/pterodactyl/panel/pull/5103.patch | patch -p1

@danny6167 danny6167 linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

3 participants