HTTPRequest is checking for chrome-only error message "Invalid header"

[juliandescottes]

Puppeteer expects that errors about headers will contain the message "Invalid header", both in the implementation and in tests:

puppeteer/packages/puppeteer-core/src/api/HTTPRequest.ts

Lines 705 to 713 in 7712dff

	export function handleError(error: ProtocolError): void {
	if (error.originalMessage.includes('Invalid header')) {
	throw error;
	}
	// In certain cases, protocol will return error if the request was
	// already canceled or the page was closed. We should tolerate these
	// errors.
	debugError(error);
	}

puppeteer/test/src/requestinterception.spec.ts

Line 763 in 7712dff

expect(error.message).toMatch(/Invalid header/);

We should find another way to handle this in a cross browser manner. Maybe we should settle on a dedicated error on the bidi side if that's helpful (see w3c/webdriver-bidi#707)

[OrKoN]

@juliandescottes is there a current message that Firefox produces that we could use short-term?

[juliandescottes]

@OrKoN I am currently implementing the support for the headers argument, but this hasn't landed yet. I don't know yet if we will wait for w3c/webdriver-bidi#707 or if we will use something else in the meantime. I will let you know once it's available (I will probably send a PR here as well)