Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatree ops.py migration cleanup #8963

Open
flamingbear opened this issue Apr 22, 2024 · 0 comments
Open

datatree ops.py migration cleanup #8963

flamingbear opened this issue Apr 22, 2024 · 0 comments
Labels
topic-DataTree Related to the implementation of a DataTree class

Comments

@flamingbear
Copy link
Contributor

What is your issue?

During the 3/26/2024 design discussion meeting (#8747), we discussed the monkey patching of methods that was required to wrap datatree nodes with the desired Xarray API function. This was a primarily done as a necessity due to the datatree code not living in the xarray repository. The better implementation could be to add the wrapping to xarray's generate_aggregations.py module. The ultimate decision made by Stephan and Tom was to add this as a future issue (this one) and migrate the file as is for now.

@flamingbear flamingbear added the needs triage Issue that has not been reviewed by xarray team member label Apr 22, 2024
@TomNicholas TomNicholas added topic-DataTree Related to the implementation of a DataTree class and removed needs triage Issue that has not been reviewed by xarray team member labels Apr 22, 2024
@TomNicholas TomNicholas added this to To do in DataTree integration via automation Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
Development

No branches or pull requests

2 participants