Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with query_objectid_as_string on Eve>=1.0.1 #1468

Open
micaelmalta opened this issue Mar 3, 2022 · 7 comments
Open

Issue with query_objectid_as_string on Eve>=1.0.1 #1468

micaelmalta opened this issue Mar 3, 2022 · 7 comments

Comments

@micaelmalta
Copy link

While migrating from Eve 1.0.0 to 1.0.1, we are seeing unexpected result with query_objectid_as_string and versioning

Expected Behavior

if query_objectid_as_string is set to true, mongo queries should not be cast as ObjectID

{ find: "string_id_accounts", filter: { _id: 'xxx' }

Actual Behavior

if query_objectid_as_string is set to true, mongo queries are cast as ObjectID

{ find: "string_id_accounts", filter: { _id: ObjectId('xxx') }

Environment

  • Python version: >=3.6
  • Eve version: >= 1.0.1

POC

https://github.com/micaelmalta/poc_eve

@nicolaiarocci nicolaiarocci mentioned this issue Mar 11, 2022
@nicolaiarocci
Copy link
Member

@Kludex are you willing to triage and eventually give a shot at this?

@Kludex
Copy link
Contributor

Kludex commented Mar 18, 2022

Yes. I'm willing to work on everything that can help us get the next release. :)

@Kludex
Copy link
Contributor

Kludex commented Mar 19, 2022

I've confirmed that the commit that introduced this behavior was: b8d8fcd

On it.

@nicolaiarocci
Copy link
Member

@Kludex any progress on this?

@Kludex
Copy link
Contributor

Kludex commented Apr 15, 2022

No 😞

@micaelmalta
Copy link
Author

@Kludex @nicolaiarocci any progress ? :(

@micaelmalta
Copy link
Author

@nicolaiarocci is it fixed in Eve 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants