Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Control #4414

Open
michnixweiss opened this issue Dec 30, 2023 · 10 comments
Open

Remote Control #4414

michnixweiss opened this issue Dec 30, 2023 · 10 comments
Assignees
Labels
feature request New enhancement request pyLoad Next

Comments

@michnixweiss
Copy link

michnixweiss commented Dec 30, 2023

Feature description

I am missing the remote section in settings.

Problem description

In pyload 0.4.20 I can configure and use remote (pyload apk) on port 7227. This is not implemented / ported to 0.5.0

@GammaC0de
Copy link
Member

@vuolter Do you have an new idea how to integrate the android app again or should we re-add the thrift backend?

@vuolter
Copy link
Contributor

vuolter commented Jan 9, 2024

@GammaC0de I have no plans for the android app right now.
Actually, if we improve the webui for mobile and tablet screens, I'd like more to keep a single lite (web) app than supporting android and ios natives.

@michnixweiss
Copy link
Author

Is there going to be a decision/solution?
I would like to further use the app. It is more usable on mobile than the web.

THX

@GammaC0de
Copy link
Member

GammaC0de commented Jan 19, 2024

I'm too in favor of using native app, I just need to find spare time for it.

P.S.

I'd like more to keep a single lite (web) app

If the is going a SPA UI that uses Angular or React, the API should be flexible enough to allow the use of native apps too.

@vuolter
Copy link
Contributor

vuolter commented Jan 20, 2024

If the is going a SPA UI that uses Angular or React, the API should be flexible enough to allow the use of native apps too.

👍

@michnixweiss
Copy link
Author

Is there any progress?

@vuolter
Copy link
Contributor

vuolter commented Feb 19, 2024

Still nothing from my side... @GammaC0de if you would make a try with thrift I think that's the fastest way to restore android/remote api capability in the meantime.

@michnixweiss
Copy link
Author

@GammaC0de are there any news or something for testing?

@GammaC0de
Copy link
Member

GammaC0de commented May 19, 2024

after looking at the code for remote control I that the whole API access needs a complete rework and modernized using REST and OpenAPI for example so the maintainability would be better.

I tried porting the Thrift but it seems a lot of work too.
Still not gave up though..

EDIT:
@vuolter Do you have and suggestions how to implement in the best way?

@vuolter
Copy link
Contributor

vuolter commented May 22, 2024

@GammaC0de thrift support was removed when the codebase was rewritten to work on Python 3 to reduce complexity and throw away oldish deps. But all the interfaces exposed by thrift was actually a 1:1 copy of the API available now through flask, so another way to restore the official android client could be update the android app to connect to pyLoad via HTTP instead of the (thrift) socket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New enhancement request pyLoad Next
Development

No branches or pull requests

3 participants