Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for resolving space in home path warning #1320

Open
Gitznik opened this issue Apr 2, 2024 Discussed in #1315 · 8 comments
Open

Improve docs for resolving space in home path warning #1320

Gitznik opened this issue Apr 2, 2024 Discussed in #1315 · 8 comments
Labels

Comments

@Gitznik
Copy link
Contributor

Gitznik commented Apr 2, 2024

How would this feature be useful?

The existing warning and docs are not enough for users to resolve it.

Describe the solution you'd like

Dedicated docs on how to move the home path and a clear link to it in the warning, as well as specifying it's the Pipx Home that has the space in it.

Describe alternatives you've considered

Hope people that are confused just find the existing discussions.

Discussed in #1315

Originally posted by homocomputeris April 1, 2024
I get the message every time I run pipx.

@Gitznik Gitznik added the docs label Apr 2, 2024
@peeeeter
Copy link

peeeeter commented Apr 5, 2024

Could you put a link to the most relevant discussion for mac os here? the only thing I found was to try "reinstall-all" but that didn't change the default bin path.

@scruffaluff
Copy link

I got the same message on MacOS everytime I used Pipx after the update to 1.5.0. The docs specify that if the folder ~/Library/Application Support/pipx exists, Pipx will prefer that folder over the default Pipx home of ~/.local/pipx. Since ~/Library/Application Support/pipx contains a space in its path, Pipx throws the space in the home path warning.

For me, running pipx uninstall-all, deleting ~/Library/Application Support/pipx, and then reinstalling my Pipx applications fixed the warning.

@Gitznik
Copy link
Contributor Author

Gitznik commented Apr 6, 2024

Thanks for providing that way of doing it @scruffaluff. That works perfectly fine if you're happy to reinstall all your pipx packages :)

The other option is described in this comment: #1315 (reply in thread)
This saves you from manually having to reinstall everything

@garthk
Copy link

garthk commented Apr 7, 2024

I'd also:

  • Amend the warning to say "PIPX_HOME" rather than "the home path"
  • … and to suggest running pipx environment
  • … and to add a link to the docs
  • Tag the issues raised for the multiple incompatibilities
  • Link to the issue search for that tag so the user has the detail necessary to assess their risk

This might strike some as a lot of fuss and bother, but I respectfully submit it's in proportion to the task you just set your users:

Found a space in the home path. We heavily discourage this, due to multiple incompatibilities. Please check our docs for more information on this, as well as some pointers on how to migrate to a different home path

@Gitznik, raising a doc-bug in response to the discussion was a good call. Onya.

@Gitznik
Copy link
Contributor Author

Gitznik commented Apr 7, 2024

Hi @garthk, Agreed to the first 3 points. Actually we should be able to create a full example of the script to run to move the pipx home right there in the warning, as we know the current and the preferred path. The user then just has to copy & paste (on mac and linux at least). A link to the docs further describing the process is a good idea as well.

For the last 2, I've opened a discussion that fully describes the reason and dangers of having a space in the path, so I think linking that/turning it into a part of the troubleshooting docs should be enough. It can be found here

Edit: Actually that discussion covers a lot more ground than just the spaces in the path, so I'll create a new one specifically for that, which can then be linked/turned into docs 👍

Edit2: Created a discussion here: #1330

@gingerbeardman
Copy link

Thanks @scruffaluff

No idea how ~/Library/Application Support/pipx was being used, i certainly didn't create it.

@albertpurnama
Copy link

Thanks @scruffaluff !

@gennaro-tedesco
Copy link

gennaro-tedesco commented May 6, 2024

No idea how ~/Library/Application Support/pipx was being used, i certainly didn't create it.

Apparently ~/Library/Application Support is the default appdir on MacOs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants