Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename USE_EMOJI to PIPX_USE_EMOJI #1395

Open
dkav opened this issue May 11, 2024 · 3 comments
Open

Rename USE_EMOJI to PIPX_USE_EMOJI #1395

dkav opened this issue May 11, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dkav
Copy link

dkav commented May 11, 2024

How would this feature be useful?
It would make easily discernible that this environmental variable is used by pipx.

Describe the solution you'd like
Replace USE_EMOJI with PIPX_USE_EMOJI

Describe alternatives you've considered
PIPX_NO_EMOJI (which is similar to Homebrew's HOMEBREW_NO_EMOJI)

@huxuan huxuan added enhancement New feature or request good first issue Good for newcomers labels May 11, 2024
@huxuan
Copy link
Contributor

huxuan commented May 11, 2024

The suggestion is good, but I have a little concern about back-compatibility. Maybe we should support the PIPX_USE_EMOJI first and have a deprecation warning for USE_EMJOI usage?

@dkav
Copy link
Author

dkav commented May 11, 2024

That sounds fair to me.

@uranusjr
Copy link
Member

We need to be careful with emitting a deprecation warning since the environment varialbe may have been set for other reasons. Maybe we should just keep supporting USE_EMOJI indefinitely but only recommend and document the variable prefixed with PIPX_.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants