Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution clang-tidy section outdated #125920

Open
bhack opened this issue May 10, 2024 · 2 comments
Open

Contribution clang-tidy section outdated #125920

bhack opened this issue May 10, 2024 · 2 comments
Labels
module: docs Related to our documentation, both in docs/ and docblocks module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@bhack
Copy link
Contributor

bhack commented May 10, 2024

馃摎 The doc issue

I cannot execute the current clang-tidy instructions on recent commits:
https://github.com/pytorch/pytorch/blob/main/CONTRIBUTING.md#running-clang-tidy

Suggest a potential alternative/fix

No response

cc @svekars @brycebortree

@soulitzer soulitzer added triage review module: docs Related to our documentation, both in docs/ and docblocks module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed triage review labels May 10, 2024
@spzala
Copy link
Contributor

spzala commented May 13, 2024

@bhack thanks for reporting the issue. It will be helpful if you can provide more information like what platform have you tried the instructions (as clang-tidy is supported for only couple of platforms), which part of instructions failed, and what was the error. Thanks!

@bhack
Copy link
Contributor Author

bhack commented May 13, 2024

Just take any official nightly image so that we are in a reproducible environment and execute the official markdown instructions I linked in the ticket.

E.g you can use yesterday image:
https://github.com/orgs/pytorch/packages/container/pytorch-nightly/215236821?tag=2.4.0.dev20240513-cuda12.4-cudnn8-devel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: docs Related to our documentation, both in docs/ and docblocks module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

3 participants