Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISABLED test_correctness_RAdam_use_closure_True_cuda_float32 (__main__.CompiledOptimizerParityTestsCUDA) #125925

Open
pytorch-bot bot opened this issue May 10, 2024 · 2 comments
Labels
module: flaky-tests Problem is a flaky test in CI module: inductor oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link

pytorch-bot bot commented May 10, 2024

Platforms: linux, slow

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 2 workflow(s) with 2 failures and 2 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_correctness_RAdam_use_closure_True_cuda_float32
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
Sample error message
Traceback (most recent call last):
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2763, in wrapper
    method(*args, **kwargs)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2763, in wrapper
    method(*args, **kwargs)
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2762, in wrapper
    with policy():
  File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2207, in __exit__
    raise RuntimeError(msg)
RuntimeError: CUDA driver API confirmed a leak in __main__.CompiledOptimizerParityTestsCUDA.test_correctness_RAdam_use_closure_True_cuda_float32! Caching allocator allocated memory was 85504 and is now reported as 93696 on device 0. CUDA driver allocated memory was 359006208 and is now 361103360.

To execute this test, run the following from the base repo dir:
    PYTORCH_TEST_CUDA_MEM_LEAK_CHECK=1 PYTORCH_TEST_WITH_SLOW_GRADCHECK=1 python test/inductor/test_compiled_optimizers.py -k CompiledOptimizerParityTestsCUDA.test_correctness_RAdam_use_closure_True_cuda_float32

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Test file path: inductor/test_compiled_optimizers.py

cc @clee2000 @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire

@pytorch-bot pytorch-bot bot added module: flaky-tests Problem is a flaky test in CI module: inductor skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 10, 2024
Copy link
Author

pytorch-bot bot commented May 10, 2024

Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_correctness_RAdam_use_closure_True_cuda_float32 (__main__.CompiledOptimizerParityTestsCUDA)
  • Platforms for which to skip the test: linux, slow
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_correctness_RAdam_use_closure_True_cuda_float32 (__main__.CompiledOptimizerParityTestsCUDA) will be disabled in PyTorch CI for these platforms: linux, slow. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

Copy link
Author

pytorch-bot bot commented May 10, 2024

Another case of trunk flakiness has been found here. The list of platforms [linux, slow] appears to contain all the recently affected platforms [linux, slow]. Either the change didn't propogate fast enough or disable bot might be broken.

pytorchmergebot pushed a commit that referenced this issue May 14, 2024
#126133)

SequentialLR and ChainedLR leak memory, so disable these two schedulers until #126131 is fixed.

Re-enables
#125925
#125925
#125924

Pull Request resolved: #126133
Approved by: https://github.com/yanboliang, https://github.com/aorenste
tinglvv pushed a commit to tinglvv/pytorch that referenced this issue May 14, 2024
pytorch#126133)

SequentialLR and ChainedLR leak memory, so disable these two schedulers until pytorch#126131 is fixed.

Re-enables
pytorch#125925
pytorch#125925
pytorch#125924

Pull Request resolved: pytorch#126133
Approved by: https://github.com/yanboliang, https://github.com/aorenste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: flaky-tests Problem is a flaky test in CI module: inductor oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

No branches or pull requests

0 participants