Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUB submodule #125997

Closed
wants to merge 3 commits into from
Closed

Remove CUB submodule #125997

wants to merge 3 commits into from

Conversation

shink
Copy link
Contributor

@shink shink commented May 11, 2024

Fixes #125981

The NVlabs/cub isn't used anymore, so it's removed in this pull request.

Copy link

pytorch-bot bot commented May 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125997

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 5443d9a with merge base d61a81a (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 11, 2024
@shink shink marked this pull request as draft May 11, 2024 07:18
@shink
Copy link
Contributor Author

shink commented May 11, 2024

there's still some work to do, convert to a draft temporarily.

@Skylion007
Copy link
Collaborator

This whole submodule isn't used anymore and can probably just be removed. (We use the version bundled with CUDA I believe).

@shink
Copy link
Contributor Author

shink commented May 13, 2024

@Skylion007 Thanks for your guidance! I'm on it. :p

@shink shink marked this pull request as ready for review May 13, 2024 07:03
@shink shink changed the title Fix CUB submodule pointing Remove CUB submodule May 13, 2024
@shink
Copy link
Contributor Author

shink commented May 13, 2024

@Skylion007 @bhack I removed cub submodule, and pytorch was installed successfully from source by running python setup.py develop. What should I do to further test the change?

@bhack
Copy link
Contributor

bhack commented May 13, 2024

We could kick-off the CI jobs suite.

@r-barnes
Copy link
Contributor

I've started the CI.

@Skylion007
Copy link
Collaborator

You also need to remove the conditional in the cmake files that tries to load the CUB sub module if the system level on cannot be found.

@bhack
Copy link
Contributor

bhack commented May 13, 2024

You also need to remove the conditional in the cmake files that tries to load the CUB sub module if the system level on cannot be found.

Do we still have this logic?

@ezyang ezyang requested a review from r-barnes May 14, 2024 18:01
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 14, 2024
@shink shink marked this pull request as draft May 16, 2024 09:29
@shink
Copy link
Contributor Author

shink commented May 20, 2024

fixed by #126540

@shink shink closed this May 20, 2024
@shink shink deleted the fix/gitsubmodule/cub branch May 20, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cub submodule still pointing to a deprecated repo
6 participants