Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cub submodule still pointing to a deprecated repo #125981

Closed
bhack opened this issue May 11, 2024 · 3 comments
Closed

Cub submodule still pointing to a deprecated repo #125981

bhack opened this issue May 11, 2024 · 3 comments
Labels
module: cuda Related to torch.cuda, and CUDA support in general module: third_party triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@bhack
Copy link
Contributor

bhack commented May 11, 2024 •
edited by pytorch-bot bot

馃悰 Describe the bug

CUB submodule is pointing to a deprecated repo.
Can we point to https://github.com/NVIDIA/cccl/ ?

Versions

Main

cc @ptrblck @msaroufim
@soulitzer soulitzer added module: cuda Related to torch.cuda, and CUDA support in general triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: third_party labels May 11, 2024
@shink shink mentioned this issue May 11, 2024
Closed
@bhack bhack mentioned this issue May 11, 2024
Closed
@ptrblck
Copy link
Collaborator

ptrblck commented May 14, 2024

third_party/cub isn't used in newer CUDA builds anymore and could be removed.
The last time I suggested this and discussed with @malfet we agreed to keep it alive for "older" CUDA builds, but I'm not sure if any of these releases is still supported.

@bhack
Copy link
Contributor Author

bhack commented May 14, 2024

We have a connected PR. CI seems fine.

@shink
Copy link
Contributor

shink commented May 20, 2024

fixed by #126540,

@bhack bhack closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: cuda Related to torch.cuda, and CUDA support in general module: third_party triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove CUB submodule shink/pytorch
4 participants
@bhack @ptrblck @soulitzer @shink