Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateDictOptions claims default strict is False, but it's actually True #125992

Closed
ad8e opened this issue May 11, 2024 · 0 comments
Closed

StateDictOptions claims default strict is False, but it's actually True #125992

ad8e opened this issue May 11, 2024 · 0 comments
Labels
module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@ad8e
Copy link
Contributor

ad8e commented May 11, 2024 •
edited by pytorch-bot bot

馃摎 The doc issue

https://pytorch.org/docs/stable/distributed.checkpoint.html#torch.distributed.checkpoint.state_dict.StateDictOptions

The default value is False.

strict: bool = True

Suggest a potential alternative/fix

I don't know which one is better. @fegin can pick.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @LucasLLC
@shink shink mentioned this issue May 11, 2024
Closed
@mikaylagawarecki mikaylagawarecki added the oncall: distributed Add this issue/PR to distributed oncall triage queue label May 14, 2024
@yf225 yf225 added module: distributed_checkpoint triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 15, 2024
ZelboK pushed a commit to ZelboK/pytorch that referenced this issue May 19, 2024
@shink @ZelboK
Fix strict default value in StateDictOptions (pytorch#125998)
255ae5d 
Fixes pytorch#125992

The default value of the parameter `strict` should be `True`.

Pull Request resolved: pytorch#125998
Approved by: https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: distributed_checkpoint oncall: distributed Add this issue/PR to distributed oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix strict default value in StateDictOptions shink/pytorch
3 participants
@yf225 @ad8e @mikaylagawarecki