Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BAAI/bge-m3 #107

Open
hogesako opened this issue Feb 3, 2024 · 8 comments
Open

Support BAAI/bge-m3 #107

hogesako opened this issue Feb 3, 2024 · 8 comments
Assignees
Labels
model request request for supporting new models

Comments

@hogesako
Copy link

hogesako commented Feb 3, 2024

Requesting support for BAAI/bge-m3. Thanks.

@NirantK NirantK self-assigned this Feb 5, 2024
@NirantK NirantK added the model request request for supporting new models label Feb 5, 2024
@NirantK
Copy link
Collaborator

NirantK commented Feb 5, 2024

[RESOLVED] Blocked on huggingface/transformers#28859

@x4080
Copy link

x4080 commented Feb 6, 2024

there's already the onnx version, is it compatible with fastembed ?

@x4080
Copy link

x4080 commented Feb 7, 2024

@NirantK Can I just add "Qdrant/bge-m3-onnx-Q" into models.json (with correct json formatting) ?

@NirantK
Copy link
Collaborator

NirantK commented Feb 8, 2024

Hey! That model has some loading issues — hence I've not integrated it yet. Somebody from the team should delete that soon from HF as well.

@x4080
Copy link

x4080 commented Feb 8, 2024

@NirantK I see thanks

@yamalight
Copy link

@NirantK is there anything external contributor can do to make this happen? seems like this would be nice first PR 😅

@elsatch
Copy link

elsatch commented Apr 2, 2024

I see that the block on the transformer library was solved on new releases.

I wonder if part of the loading issues are related to the support from the model of the three kinds of vectors: sparse, dense and multi-vent (colBERT).

@NirantK
Copy link
Collaborator

NirantK commented Apr 2, 2024

Hey @elsatch - yes, the 2 linear models for Sparse and multi-vec need to have an ONNX export and loader as well. That's something we've to do for now. We can support the dense model without friction but I'd rather avoid the confusion and support all 3 vectors when we support BGE-M3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model request request for supporting new models
Projects
None yet
Development

No branches or pull requests

5 participants