Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggingTriggerHistoryPlugin and LoggingJobHistoryPlugin should use StructuredLogging #2217

Open
michaelmairegger opened this issue Dec 12, 2023 · 1 comment

Comments

@michaelmairegger
Copy link

michaelmairegger commented Dec 12, 2023

Currently the log is written as string. For better logging those plugins should use structured loggings.

Additionally to that every call to Log.XXX should use structured logging.

@jafin
Copy link
Contributor

jafin commented Mar 7, 2024

I started to take a look at this, once structured logging is introduced, I think it makes less sense to provide ability to configure your own log template message, which the current plugin does. As the order of the parameters, not the placeholder index takes effect. I'll put up a PR for review, and see if this is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants