Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: kill Diag_Collector and Buffering_Diag_Reporter #1154

Open
strager opened this issue Jan 3, 2024 · 1 comment
Open

refactor: kill Diag_Collector and Buffering_Diag_Reporter #1154

strager opened this issue Jan 3, 2024 · 1 comment

Comments

@strager
Copy link
Collaborator

strager commented Jan 3, 2024

No description provided.

strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(fe): use Diag_List in lexer transactions
b3cd177 
Replace Buffering_Diag_Reporter with Diag_List so we can eventually
kill Buffering_Diag_Reporter.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): avoid Diag_Collector in most uses of Test_Parser
dcaf585 
I want to kill Diag_Collector. Move some users over to Diag_List.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): remove Diag_Collector from Spy_Visitor
04cd4b7 
I want to get rid of Diag_Collector. Delete Spy_Visitor's
Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): avoid Diag_Collector in most lexer tests
90d63c4 
Switch most lexer tests to use Diag_List instead of Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): allow Diagnostic_Assertion to work with manual offsets
ca9ce31 
Some tests cannot use the u8"^^^ Diag_Foo"_diag syntax and instead
need to work with manual offsets. Make this possible with
diagnostic_assertions. This will help us remove Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): replace DIAG_TYPE_OFFSETS -> DIAGNOSTIC_ASSERTION_SPAN
c14c22f 
#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): replace some uses of DIAG_TYPE
32425fb 
I want to remove the Diag_Collector-based matchers. Remove some uses
of DIAG_TYPE.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): avoid Diag_Collector in Variable_Analyzer test
7b32181 
#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): replace DIAG_TYPE_OFFSETS -> DIAGNOSTIC_ASSERTION_SPAN
cde5cd0 
#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): replace some uses of DIAG_TYPE
7a02e23 
I want to remove the Diag_Collector-based matchers. Remove some uses
of DIAG_TYPE.

#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): avoid Diag_Collector in Variable_Analyzer test
46d5fcf 
#1154
strager added a commit that referenced this issue Jan 7, 2024
@strager
refactor(test): avoid Diag_Collector in more tests
d7f865a 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(fe): use Diag_List in lexer transactions
0baa389 
Replace Buffering_Diag_Reporter with Diag_List so we can eventually
kill Buffering_Diag_Reporter.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in most uses of Test_Parser
3a82cdc 
I want to kill Diag_Collector. Move some users over to Diag_List.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): remove Diag_Collector from Spy_Visitor
cb103bc 
I want to get rid of Diag_Collector. Delete Spy_Visitor's
Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in most lexer tests
281a810 
Switch most lexer tests to use Diag_List instead of Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): allow Diagnostic_Assertion to work with manual offsets
0506750 
Some tests cannot use the u8"^^^ Diag_Foo"_diag syntax and instead
need to work with manual offsets. Make this possible with
diagnostic_assertions. This will help us remove Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): replace DIAG_TYPE_OFFSETS -> DIAGNOSTIC_ASSERTION_SPAN
9cc81cd 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): replace some uses of DIAG_TYPE
284bad6 
I want to remove the Diag_Collector-based matchers. Remove some uses
of DIAG_TYPE.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in Variable_Analyzer test
85aa52f 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in more tests
a5028d3 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(fe): use Diag_List in lexer transactions
82cbbc3 
Replace Buffering_Diag_Reporter with Diag_List so we can eventually
kill Buffering_Diag_Reporter.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in most uses of Test_Parser
ab00e85 
I want to kill Diag_Collector. Move some users over to Diag_List.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): remove Diag_Collector from Spy_Visitor
a585569 
I want to get rid of Diag_Collector. Delete Spy_Visitor's
Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in most lexer tests
bc783a6 
Switch most lexer tests to use Diag_List instead of Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): allow Diagnostic_Assertion to work with manual offsets
b52a461 
Some tests cannot use the u8"^^^ Diag_Foo"_diag syntax and instead
need to work with manual offsets. Make this possible with
diagnostic_assertions. This will help us remove Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): replace DIAG_TYPE_OFFSETS -> DIAGNOSTIC_ASSERTION_SPAN
f5e3da6 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): replace some uses of DIAG_TYPE
92b1589 
I want to remove the Diag_Collector-based matchers. Remove some uses
of DIAG_TYPE.

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in Variable_Analyzer test
50986af 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): avoid Diag_Collector in more tests
8fb50e8 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): replace DIAG_TYPE_2_OFFSETS -> DIAGNOSTIC_ASSERTION_2…
daf3863 
…_SPANS

#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): remove last use of DIAG_TYPE_2_OFFSETS
dec7904 
#1154
strager added a commit that referenced this issue Jan 8, 2024
@strager
refactor(test): replace use of DIAG_TYPE_OFFSETS with DIAGNOSTIC_ASSE…
f1d4fa6 
…RTION_SPAN

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): allow Diagnostic_Assertion to work with manual offsets
1f99ad1 
Some tests cannot use the u8"^^^ Diag_Foo"_diag syntax and instead
need to work with manual offsets. Make this possible with
diagnostic_assertions. This will help us remove Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace DIAG_TYPE_OFFSETS -> DIAGNOSTIC_ASSERTION_SPAN
96d3b7c 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace some uses of DIAG_TYPE
7ce1ceb 
I want to remove the Diag_Collector-based matchers. Remove some uses
of DIAG_TYPE.

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): avoid Diag_Collector in Variable_Analyzer test
53d3b7d 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): avoid Diag_Collector in more tests
273cad8 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace DIAG_TYPE_2_OFFSETS -> DIAGNOSTIC_ASSERTION_2…
9d29107 
…_SPANS

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): remove last use of DIAG_TYPE_2_OFFSETS
6fe3d87 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace use of DIAG_TYPE_OFFSETS with DIAGNOSTIC_ASSE…
e9e8804 
…RTION_SPAN

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): allow Diagnostic_Assertion to work with manual offsets
bf424b1 
Some tests cannot use the u8"^^^ Diag_Foo"_diag syntax and instead
need to work with manual offsets. Make this possible with
diagnostic_assertions. This will help us remove Diag_Collector.

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace DIAG_TYPE_OFFSETS -> DIAGNOSTIC_ASSERTION_SPAN
2ad2c57 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace some uses of DIAG_TYPE
641dbd9 
I want to remove the Diag_Collector-based matchers. Remove some uses
of DIAG_TYPE.

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): avoid Diag_Collector in Variable_Analyzer test
504148f 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): avoid Diag_Collector in more tests
ece8f2f 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace DIAG_TYPE_2_OFFSETS -> DIAGNOSTIC_ASSERTION_2…
262ad6c 
…_SPANS

#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): remove last use of DIAG_TYPE_2_OFFSETS
56bdadb 
#1154
strager added a commit that referenced this issue Jan 9, 2024
@strager
refactor(test): replace use of DIAG_TYPE_OFFSETS with DIAGNOSTIC_ASSE…
e848ab5 
…RTION_SPAN

#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): remove Test_Parser::legacy_errors()
3b1c78d 
Remove all calls, then remove the now-unused function.

#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): prefer Diag_List_Diag_Reporter over Diag_Collector
54a7e1c 
#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): remove Diag_Collector asserts from test-lex.cpp
7a3de9f 
Use the Diag_List-based functions instead.

#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): delete Diag_Collector-based assert matcher code
b2961f5 
This is dead code. Delete it.

#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): delete Diag_Collector
f3fbbc3 
This class is unused.

#1154
@strager
Copy link
Collaborator Author

strager commented Mar 6, 2024 •
edited

Diag_Collector is gone. 👍 (EDIT: Almost.)

Buffering_Diag_Reporter will take some work to rip out.

strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): remove Diag_Collector asserts from test-lex.cpp
258781c 
Use the Diag_List-based functions instead.

#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): delete Diag_Collector-based assert matcher code
dda855b 
This is dead code. Delete it.

#1154
strager added a commit that referenced this issue Mar 6, 2024
@strager
refactor(test): delete Diag_Collector
7239320 
This class is unused.

#1154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@strager