Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log spamming #4995

Closed
fulmicoton opened this issue May 16, 2024 · 5 comments · Fixed by #4997 or #5001
Closed

Log spamming #4995

fulmicoton opened this issue May 16, 2024 · 5 comments · Fixed by #4997 or #5001
Assignees
Labels
bug Something isn't working

Comments

@fulmicoton
Copy link
Contributor

As observed on airmail.

Quickwit ended up spamming the following logs:

insertion rejected due to {\"message\":\"index ID pattern `_bulk` is invalid: patterns must match the following regular expression: `^[a-zA-Z\\\\*][a-zA-Z0-9-_\\\\.\\\\*]{0,254}$`\"}`

The indexes are using ingest v2 and are created via the index template.

@fulmicoton fulmicoton added the bug Something isn't working label May 16, 2024
@fulmicoton
Copy link
Contributor Author

(This is most likely a validation problem. We need to early, with rate limited logging, invalid index patterns)

@esatterwhite
Copy link

We don't attempt to insert into an index named _bulk ever. I think that might be the bug. Nothing had changed on our side. After the last up date today, we started getting that error

@trinity-1686a
Copy link
Contributor

hum, @esatterwhite could you provide us with a sample of the requests your client sent?
i couldn't find a way to reproduce that issue in which it worked before, and fails now, but I do get the same error message if i switch from POST to PUT when using the bulk API. Elastic documentation doesn't seem to say that's possible, but actually Elastic accepts such query, and Quickwit thinks it's a normal, non bulk insertion, for an index called _bulk

@fulmicoton
Copy link
Contributor Author

@esatterwhite is probably right. If you observed it for PUT, it is probably a side effect of shedloading I introduced in
b97f398

@fulmicoton
Copy link
Contributor Author

fulmicoton commented May 17, 2024

Confirmed, I manage to reproduce with


export QW_INGEST_MAX_IN_FLIGHT=0


http POST http://localhost:7280/api/v1/_elastic/_bulk/ < es_batch2.json
HTTP/1.1 400 Bad Request
content-type: application/json
date: Fri, 17 May 2024 15:42:57 GMT
transfer-encoding: chunked
vary: origin
vary: access-control-request-method
vary: access-control-request-headers

{
    "message": "index ID pattern `_bulk` is invalid: patterns must match the following regular expression: `^[a-zA-Z\\*][a-zA-Z0-9-_\\.\\*]{0,254}$`"
}

I still don't know which endpoint it is rerouted too though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants