Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify cache metrics #4583

Open
fmassot opened this issue Feb 14, 2024 · 1 comment · May be fixed by #5002
Open

Simplify cache metrics #4583

fmassot opened this issue Feb 14, 2024 · 1 comment · May be fixed by #5002
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fmassot
Copy link
Contributor

fmassot commented Feb 14, 2024 •
edited

We have separate metrics for fastfields, shortlived, splitfooter caches.

We could just use labels fastfields, shortlived, splitfooter instead.

So in end we have the following metrics:

  • quickwit_cache_in_cache_count
  • quickwit_cache_in_cache_num_bytes
  • quickwit_cache_hit_total
  • quickwit_cache_ hits_bytes
  • quickwit_cache_miss_total
@fmassot fmassot added enhancement New feature or request good first issue Good for newcomers labels Feb 14, 2024
@Surya361
Copy link

Is this only for fastfields, shortlived and splitfooter metrics or should we extend it to all cache metrics such as fdcache, partial_request etc.

@Surya361 Surya361 linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unified cache metrics Surya361/quickwit
2 participants
@fmassot @Surya361