Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conflict Next 14 / React 18 & @quillforms/renderer-core #163

Open
emilthemaker opened this issue Jan 31, 2024 · 4 comments
Open

conflict Next 14 / React 18 & @quillforms/renderer-core #163

emilthemaker opened this issue Jan 31, 2024 · 4 comments

Comments

@emilthemaker
Copy link

Describe the bug
Can't install Quillforms because @wordpress/components, which is required by @quillforms/renderer-core needs Reakit, which seems to not work with React 18.

This warning occurs, and it's breaking on the site:

npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: reakit@1.3.11
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from react-autosize-textarea@7.1.0
npm WARN   node_modules/@quillforms/blocklib-long-text-block/node_modules/react-autosize-textarea
npm WARN     react-autosize-textarea@"^7.1.0" from @quillforms/blocklib-long-text-block@3.0.45
npm WARN     node_modules/@quillforms/blocklib-long-text-block
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN node_modules/reakit
npm WARN   reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN   node_modules/@wordpress/components
npm WARN 
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN   node_modules/reakit
npm WARN     reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN     node_modules/@wordpress/components
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: reakit@1.3.11
npm WARN Found: react-dom@18.2.0
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^0.14.0 || ^15.0.0 || ^16.0.0" from react-autosize-textarea@7.1.0
npm WARN   node_modules/@quillforms/blocklib-long-text-block/node_modules/react-autosize-textarea
npm WARN     react-autosize-textarea@"^7.1.0" from @quillforms/blocklib-long-text-block@3.0.45
npm WARN     node_modules/@quillforms/blocklib-long-text-block
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN node_modules/reakit
npm WARN   reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN   node_modules/@wordpress/components
npm WARN 
npm WARN Conflicting peer dependency: react-dom@17.0.2
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN   node_modules/reakit
npm WARN     reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN     node_modules/@wordpress/components
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency

To Reproduce
Steps to reproduce the behavior:

  1. Get these dependencies:
"dependencies": {
    "@headlessui/react": "^1.7.17",
    "@heroicons/react": "^2.0.18",
    "next": "14.0.3",
    "react": "^18",
    "react-dom": "^18",
    "swiper": "^8.4.7"
  },
  1. Install quillforms as described in docs
    npm i @quillforms/renderer-core @quillforms/react-renderer-utils

Expected behavior
Should install like expected.
@emilthemaker
Copy link
Author

UPDATE:
Can replicate this conflict without any other deps installed:

➜  test npm i @quillforms/renderer-core                                 

added 233 packages, and audited 234 packages in 10s

22 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
➜  test npm i @quillforms/react-renderer-utils
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: reakit@1.3.11
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   peer react@"^0.14.0 || ^15.0.0 || ^16.0.0" from react-autosize-textarea@7.1.0
npm WARN   node_modules/@quillforms/blocklib-long-text-block/node_modules/react-autosize-textarea
npm WARN     react-autosize-textarea@"^7.1.0" from @quillforms/blocklib-long-text-block@3.0.45
npm WARN     node_modules/@quillforms/blocklib-long-text-block
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN node_modules/reakit
npm WARN   reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN   node_modules/@wordpress/components
npm WARN 
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN   node_modules/reakit
npm WARN     reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN     node_modules/@wordpress/components
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: reakit@1.3.11
npm WARN Found: react-dom@18.2.0
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^0.14.0 || ^15.0.0 || ^16.0.0" from react-autosize-textarea@7.1.0
npm WARN   node_modules/@quillforms/blocklib-long-text-block/node_modules/react-autosize-textarea
npm WARN     react-autosize-textarea@"^7.1.0" from @quillforms/blocklib-long-text-block@3.0.45
npm WARN     node_modules/@quillforms/blocklib-long-text-block
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react-dom@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN node_modules/reakit
npm WARN   reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN   node_modules/@wordpress/components
npm WARN 
npm WARN Conflicting peer dependency: react-dom@17.0.2
npm WARN node_modules/react-dom
npm WARN   peer react-dom@"^16.8.0 || ^17.0.0" from reakit@1.3.11
npm WARN   node_modules/reakit
npm WARN     reakit@"^1.3.11" from @wordpress/components@23.9.0
npm WARN     node_modules/@wordpress/components
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency

added 167 packages, and audited 401 packages in 19s

37 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

@prurph
Copy link

prurph commented Mar 22, 2024

Also running into this.

@Sh1n
Copy link

Sh1n commented Apr 11, 2024

Same here

@mdmag
Copy link
Member

mdmag commented Apr 13, 2024

Hello @Sh1n , @prurph, @emilthemaker
I just released these new versions:

  "@quillforms/react-renderer-utils": "^5.11.0",
  "@quillforms/renderer-core": "^5.9.0"

Hopefully, the issue is fixed now. Can you please update and confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Sh1n @prurph @mdmag @emilthemaker