-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a option to support games with 3d disabled #285
Comments
Been looking a bit into this, and can replicate the issue. Is the workaround that you're describing a case of modifying the source code and then compile an export template with |
@ramokz sorry, I mean modifying the source code of phantom-camera ( remove all PhantomCamera3D and Camera3D mainly in plugin.gd, phantom_camera_3d.gd phantom_camera_host.gd) |
Gotcha, yes, that's not an ideal workflow to deal with. I am not sure if there's a way around it without having to make the reference to Can't verify if this is true, but would suspect it would be more durable with a GDExtension rewrite of the addon, as that would allow for better modularity, but don't see that happening anytime soon. |
I think there is a way. Built-in class is registered in ClassDB so it can be detected if 3d is enabled by ClassDB.class_exists("Camera3D"). There is also object.is_class("class_name"), or object.get_class(), so |
You're right, made it work without changing too many things. Only needed to override the built-in functions of From a few export samples, it doesn't appear that changing the I'm still not a fan of the loosely typed approach, but am an even less of a fan of not supporting this. |
Project Type
2D
Feature Description
Currently this addon doesn't work with export template compiled with
disable_3d=yes
becase it depends on Camera3D. Users have to manually modify the source code to support 2d-only export template, which is Inconvenient.Use Cases
For games using export template compiled with
disable_3d=yes
(Optional) Proposed Solution
No response
The text was updated successfully, but these errors were encountered: