Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove webhook direct dependency on RKE #45431

Open
MbolotSuse opened this issue May 9, 2024 · 0 comments
Open

Remove webhook direct dependency on RKE #45431

MbolotSuse opened this issue May 9, 2024 · 0 comments
Labels
kind/tech-debt Formerly issues labeled as ci-improvements, tasks, flaky tests, and post-release. priority/0 team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Milestone
v2.9-Next1

Comments

@MbolotSuse
Copy link
Contributor

Currently, the Rancher webhook has a direct dependency on RKE. This can result in issues if the RKE version isn't synchronized with the Rancher version, as seen in #44980. This seems to be only added for usage in a single test.

To avoid extra process, we should re-write this test to not use this import. At minimum, we could write the test using a raw string (representing a JSON object) and marshal it into the cluster type. Note that this will still be an indirect import, even after this change.
@MbolotSuse MbolotSuse added priority/0 kind/tech-debt Formerly issues labeled as ci-improvements, tasks, flaky tests, and post-release. team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas labels May 9, 2024
@MbolotSuse MbolotSuse added this to the v2.9-Next1 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/tech-debt Formerly issues labeled as ci-improvements, tasks, flaky tests, and post-release. priority/0 team/frameworks the team that is responsible for frameworks, projects, webhook, and other various areas
Projects
None yet
Milestone
v2.9-Next1
Development

No branches or pull requests
1 participant
@MbolotSuse