Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for docker 26.1.x #45439

Open
mitulshah-suse opened this issue May 10, 2024 · 5 comments
Open

Add support for docker 26.1.x #45439

mitulshah-suse opened this issue May 10, 2024 · 5 comments
Assignees
@vivek-shilimkar
Labels
priority/0 team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support team/infracloud
Milestone
v2.9-Next1

Comments

@mitulshah-suse
Copy link

Add support for docker 26.1.x.
Release notes: https://docs.docker.com/engine/release-notes/26.1/

ref issue: #45013

Docker versions added: 26.1.0 and 26.1.1
@mitulshah-suse mitulshah-suse added team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support team/infracloud labels May 10, 2024
@mitulshah-suse mitulshah-suse added this to the v2.9-Next1 milestone May 10, 2024
@chiukapoor chiukapoor mentioned this issue May 10, 2024
Merged
@vivek-shilimkar vivek-shilimkar self-assigned this May 10, 2024
@mitulshah-suse mitulshah-suse mentioned this issue May 10, 2024
Merged
@chiukapoor chiukapoor mentioned this issue May 10, 2024
Open
@vivek-shilimkar
Copy link
Member

Validated on rancher v2.9-head

Docker 26.1.0 and 26.1.1 validation completed on below OSes with node driver and custom clusters:

  • RHEL 9.3 and 8.9
  • OL 9.3 and 8.9
  • Rocky 9.3 and 8.9
  • CentOS 7.9
  • Ubuntu 22.04

@vivek-shilimkar
Copy link
Member

vivek-shilimkar commented May 15, 2024 •
edited

Validated on rancher v2.9-head
Docker 26.1.0 and 26.1.1 validation completed on below OSes with node driver and custom clusters:

  • RHEL 9.2, 9.1, 9.0, 8.8, and 8.7
  • OL 9.2, 9.1, 8.8 and 8.7
  • Rocky 9.2, 9.1, 8.8 and 8.7
  • Ubuntu 24.04

@kinarashah
Copy link
Member

kinarashah commented May 17, 2024 •
edited

26.1.0 and 26.1.1 released

@mitulshah-suse
Copy link
Author

Moving back to raise the rancher PRs to update the default versions, since testing and release are compeleted.

@chiukapoor chiukapoor mentioned this issue May 20, 2024
Merged
@chiukapoor chiukapoor mentioned this issue May 22, 2024
Open
@chiukapoor
Copy link
Contributor

Hello @snasovich & @kinarashah, I was wondering if we may point to EngineInstallURL from setting.go for install-docker script URL in controller.go?

rancher/pkg/controllers/management/node/controller.go

Line 48 in 49a10b3

defaultEngineInstallURL = "https://releases.rancher.com/install-docker/26.0.sh"

rancher/pkg/settings/setting.go

Line 66 in 49a10b3

EngineInstallURL = NewSetting("engine-install-url", "https://releases.rancher.com/install-docker/26.0.sh")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivek-shilimkar vivek-shilimkar

Labels
priority/0 team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support team/infracloud
Projects
None yet
Milestone
v2.9-Next1
Development

No branches or pull requests
5 participants
@kinarashah @chiukapoor @vivek-shilimkar @snasovich @mitulshah-suse