Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Add deprecation warning on SRIOV chart in UI #11042

Open
manuelbuil opened this issue May 10, 2024 · 4 comments
Open

[RFE] Add deprecation warning on SRIOV chart in UI #11042

manuelbuil opened this issue May 10, 2024 · 4 comments
Labels
kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this release-note
Milestone

Comments

@manuelbuil
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

SRIOV charts will no longer be updated in https://github.com/rancher/charts because their new home is https://github.com/suse-edge/charts. If a user wants to consume SRIOV chart, that user will need to include the new helm repo in Rancher. Currently, the chart is in sync in both repos.

For the v2.9 release, charts will continue to be in both helm repos. For the v2.10 release we expect the chart to not be available via Rancher default charts Therefore, it would be nice to add a deprecation warning in v2.9 so that users are aware of the situation and know what is the way forward.

Describe the solution you'd like
A clear and concise description of what you want to happen.

I would like to add a warning in the UI so that users picking SRIOV chart know that it is deprecated and that it will be removed in the v2.10 cycle

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@manuelbuil
Copy link
Author

@mgfritch FYI

@gaktive gaktive transferred this issue from rancher/rancher May 16, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label May 16, 2024
@gaktive gaktive added this to the v2.9.0 milestone May 16, 2024
@gaktive
Copy link
Member

gaktive commented May 21, 2024

Proposed copy:

(With a Warning sign) This chart will no longer be updated and be removed in 2.10. Please migrate to https://github.com/suse-edge/charts. Check the migrating guide for more information [link]

This may require a corresponding ticket in https://github.com/rancher/docs but putting release-note on this to start. @btat what's the best way to proceed? @manuelbuil will have more details.

@manuelbuil
Copy link
Author

I have tested today and the upgrade is pretty painless if you use the same name to install the chart coming from the edge repo. As it does a helm upgrade behind the curtains, the new version of the chart points at the new chart:

azureuser@terraform-mbuil-vm1:~$ helm history sriov -n cattle-sriov-system
REVISION	UPDATED                 	STATUS    	CHART                               	APP VERSION	DESCRIPTION     
1       	Tue May 21 14:15:27 2024	superseded	sriov-103.1.0+up0.1.0               	1.2.0      	Install complete
2       	Tue May 21 15:09:25 2024	deployed  	sriov-network-operator-1.2.3+up0.1.0	1.2.0      	Upgrade complete
azureuser@terraform-mbuil-vm1:~$ helm history sriov-crd -n cattle-sriov-system
REVISION	UPDATED                 	STATUS    	CHART                    	APP VERSION	DESCRIPTION     
1       	Tue May 21 14:15:25 2024	superseded	sriov-crd-103.1.0+up0.1.0	           	Install complete
2       	Tue May 21 15:09:24 2024	deployed  	sriov-crd-1.2.3+up0.1.0  	           	Upgrade complete

@btat
Copy link

btat commented May 21, 2024

@gaktive @manuelbuil I created rancher/rancher-docs#1297 for the docs portion. We can move docs-specific discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this release-note
Projects
None yet
Development

No branches or pull requests

3 participants