Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for termination criterion with tolerance #1079

Open
GMi-Materials opened this issue Jan 18, 2024 · 1 comment
Open

Add option for termination criterion with tolerance #1079

GMi-Materials opened this issue Jan 18, 2024 · 1 comment

Comments

@GMi-Materials
Copy link

Describe the workflow you want to enable

Add an option for a termination criterion similar to "tol" implemented in sklearn.feature_selection.SequentialFeatureSelector:
https://scikit-learn.org/stable/modules/generated/sklearn.feature_selection.SequentialFeatureSelector.html

Describe alternatives you've considered, if relevant

While the sklearn SequentialFeatureSelector can do this, it misses the history callback you get in this package, which i think is very nice and helpful.

Additional context

The version of mlxtend i am using is 0.23.1

@rasbt
Copy link
Owner

rasbt commented Jan 18, 2024

Thanks for the note, I agree that this would be a good addition! I may not be able to add it soonish but would be happy about any contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants