Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are not passing in the branch main #982

Open
NimaSarajpoor opened this issue Nov 7, 2022 · 5 comments
Open

tests are not passing in the branch main #982

NimaSarajpoor opened this issue Nov 7, 2022 · 5 comments
Labels

Comments

@NimaSarajpoor
Copy link
Contributor

It seems that the test functions for feature_selection are not passing in the branch main.

I got:

# run in bash: pytest mlxtend/feature_selection/tests/.

####

================= 24 failed, 71 passed, 15 warnings in 34.95s =================

@rasbt
Copy link
Owner

rasbt commented Nov 8, 2022

Huh that's weird. I haven't touched anything recently. It might be due to some recent package updates. Some packages don't have pinned versions and could be the culprit (https://github.com/rasbt/mlxtend/blob/master/.github/workflows/python-package-conda.yml) have to look into that.

@rasbt
Copy link
Owner

rasbt commented Nov 8, 2022

or just to clarify, was it the CI or local testing?

@NimaSarajpoor
Copy link
Contributor Author

So, if I understand correctly, by "local testing" you meant the testing on just a part of software. Right? If yes, then yeah... it was local testing on feature_selection. I did not check the others.

@NimaSarajpoor
Copy link
Contributor Author

@rasbt
Quick update:
I just ran it in another PC and all tests are passing!

But, isn't it weird that I faced such issue in the other PC? I mean... I should have got an error regarding the version of a dependency instead of seeing some tests getting failed. Right?

@rasbt
Copy link
Owner

rasbt commented Nov 8, 2022

@NimaSarajpoor With "local" testing I meant locally on your computer 😅. It's weird that it worked on the other machine, but I am also glad to hear that there are no issues there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants