Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up plugin service contract #588

Open
1 of 2 tasks
irainia opened this issue Sep 12, 2022 · 0 comments
Open
1 of 2 tasks

clean up plugin service contract #588

irainia opened this issue Sep 12, 2022 · 0 comments
Labels
refactor Internal code improvement
Milestone

Comments

@irainia
Copy link
Member

irainia commented Sep 12, 2022

Description
This issue is part of this discussion. There are two issues in the mechanism when we want to get upstream resource urn:

  • we require the whole project spec and namespace spec
  • the method name is not really clear, whether it's a resource name or resource urn GenerateDependencies

Acceptance Criteria

We need to refactor the plugin service to address the mentioned issues above.

  • Change GenerateDependencies into GenerateUpstreamResourceURNs
  • Ensure that when calling the method, only the required parameter is passed
@irainia irainia added the refactor Internal code improvement label Sep 12, 2022
@irainia irainia added this to the Code CleanUp milestone Sep 12, 2022
@irainia irainia changed the title refactor: clean up plugin service contract clean up plugin service contract Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal code improvement
Projects
None yet
Development

No branches or pull requests

1 participant